Setting HasStarted to true when calling StartAsync #1808
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bozalina, Thank you for contributing the PR. Our team will review it and get back to you as soon we can. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This fixes a bug when running a gRPC-Web service in Lambda where trailers are not properly written as part of the response payload because the response feature hasn't been marked as started. The check for
HasStartedwhen selecting the trailers destination in gRPC .NET is here.Calling
StartAsyncnow marks the response feature as started. I also added unit tests to check the default value forHasStartedand the value after callingStartAsync.Unit tests are passing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.